fix looker3d controls styles in light theme #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. For consistency, can the grey border be removed from the Looker3d controls row? It also looks like the the icons are smaller in Looker3d. And there is no animation on hover, but that is a smaller detail. |
imanjra
force-pushed
the
bugfix/looker3d-controls-style
branch
from
49eafa6
to
115fdd8
Compare
imanjra
force-pushed
the
bugfix/looker3d-controls-style
branch
from
115fdd8
to
0781cad
Compare
brimoor
requested changes
Nov 5, 2022
There was a problem hiding this comment.
@imanjra can you address these related items before merging?
-
Clicking the
?icon in Looker3D a second time does not close the help menu (it immediately reopens) -
This Looker3D component needs to respect light theme
- The close modal buttons are inconsistent in light theme (I think dark color makes sense)
- This overlay text should be white in both dark and light theme:
- Remove shadow from Looker3D's toolbar for consistency with Looker2D's toolbar:
- Use same darker background for JSON viewer that is used in help menu (too difficult to read the JSON viewer currently). Also I think the transparency is too much right now. Better to make it more opaque so the modal text is easier to read:
ritch
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Improve Looker3D controls styles to make it consistent with looker 2D controls styles
How is this patch tested? If it is not, please explain why.
Tested visually in both light and dark theme
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyonePython library changes